This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v1 1/3] Add AVX512 registers support to GDB.
- From: Pedro Alves <palves at redhat dot com>
- To: Michael Sturm <michael dot sturm at intel dot com>
- Cc: eliz at gnu dot org, mark dot kettenis at xs4all dot nl, walfred dot tedeschi at intel dot com, gdb-patches at sourceware dot org
- Date: Fri, 20 Dec 2013 17:29:21 +0000
- Subject: Re: [PATCH v1 1/3] Add AVX512 registers support to GDB.
- Authentication-results: sourceware.org; auth=none
- References: <1387533175-4039-1-git-send-email-michael dot sturm at intel dot com> <1387533175-4039-2-git-send-email-michael dot sturm at intel dot com>
Hi there,
I skimmed this (not a real review), and noticed:
> +send_gdb "print have_avx512 ()\r"
> +gdb_expect {
Please use gdb_test_multiple instead of send_gdb/gdb_expect.
> + -re ".. = 1\r\n$gdb_prompt " {
> + pass "check whether processor supports AVX512"
> + }
> + -re ".. = 0\r\n$gdb_prompt " {
Should be a pass too:
pass "check whether processor supports AVX512"
As the test did its job.
> + }
> + -re ".*$gdb_prompt $" {
> + fail "check whether processor supports AVX512"
> + }
> + timeout {
> + fail "check whether processor supports AVX512 (timeout)"
> + }
These last two won't be necessary then.
> +}
> +
This:
> + verbose "processor does not support AVX512; skipping AVX512 tests"
> + return
should probably instead be:
unsupported "processor does not support AVX512; skipping AVX512 tests"
...
> +}
> \ No newline at end of file
Please add one.
--
Pedro Alves