This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Yufeng Zhang <Yufeng dot Zhang at arm dot com>, GDB Patches <gdb-patches at sourceware dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Sat, 28 Dec 2013 14:21:57 -0200
- Subject: Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
- Authentication-results: sourceware.org; auth=none
- References: <m38uvgmqjk dot fsf at redhat dot com> <52B86A61 dot 1010004 at arm dot com> <m3ioufjxk2 dot fsf at redhat dot com> <20131228033514 dot GE4532 at adacore dot com>
On Saturday, December 28 2013, Joel Brobecker wrote:
>> 2013-12-23 Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * NEWS: Mention SystemTap SDT probe support for AArch64 GNU/Linux.
>> * aarch64-linux-tdep.c: Include necessary headers for parsing of
>> SystemTap SDT probes.
>> (aarch64_stap_is_single_operand): New function.
>> (aarch64_stap_parse_special_token): Likewise.
>> (aarch64_linux_init_abi): Declare SystemTap SDT probe argument
>> prefixes and suffixes. Initialize gdbarch with them.
>
> First of all, thanks to Yufeng and Marcus for reviewing the patch.
> That was very useful.
>
> The patch is therefore approved, with one small request:
Thanks a lot, Joel.
>> }
>>
>> +static int
>> +aarch64_stap_is_single_operand (struct gdbarch *gdbarch, const char *s)
>> +{
>> + return (*s == '#' || isdigit (*s) /* Literal number. */
>> + || *s == '[' /* Register indirection. */
>> + || isalpha (*s)); /* Register value. */
>> +}
>
> Can you document this function?
Yes, fixed.
Checked in:
<https://sourceware.org/ml/gdb-cvs/2013-12/msg00123.html>
Thanks,
--
Sergio