This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/5] Fix for D demangling in GDB
- From: Tom Tromey <tromey at redhat dot com>
- To: Iain Buclaw <ibuclaw at gdcproject dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Jan 2014 14:45:38 -0700
- Subject: Re: [PATCH 5/5] Fix for D demangling in GDB
- Authentication-results: sourceware.org; auth=none
- References: <CABOHX+fr7hyD0WM-=1G4zcoJH61uPiE9ezYSYmKuUoqvZnLmvA at mail dot gmail dot com> <87zjn47ref dot fsf at fleche dot redhat dot com> <CABOHX+dXQQjpE2-S3wM5Qcrq=i29HewDzRptXcrn0=T+EVjOrg at mail dot gmail dot com> <CABOHX+e2pJ6eM0_29iQ6QEDhB43x9iN8u+6ROTXfn9NBYLnrQw at mail dot gmail dot com>
>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
Iain> Second change, move D demangling routines out of d-lang.c into
Iain> d-support.c, which is intended to house other language support
Iain> functions that don't really have a home elsewhere.
Thanks.
Iain> * d-lang.c (parse_call_convention)
Iain> (parse_attributes, parse_function_types)
Iain> (parse_function_args, parse_type, parse_identifier)
Iain> (call_convention_p, d_parse_symbol): Move functions to ...
Iain> * d-support.c: ... New file.
This should mention the Makefile.in change, like:
* Makefile.in (SFILES): Add d-support.c.
(COMMON_OBS): Add d-support.o.
... and the d-lang.h change, even though it is trivial.
Otherwise the patch is fine.
Tom