This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 03/32] introduce async_callback_ftype
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 14 Jan 2014 21:18:59 +0400
- Subject: Re: [RFC 03/32] introduce async_callback_ftype
- Authentication-results: sourceware.org; auth=none
- References: <1389640367-5571-1-git-send-email-tromey at redhat dot com> <1389640367-5571-4-git-send-email-tromey at redhat dot com> <52D512FB dot 7010006 at redhat dot com> <20140114105012 dot GF4762 at adacore dot com> <87a9eyy55d dot fsf at fleche dot redhat dot com>
> /* The type of the callback to the to_async method. */
>
> typedef void async_callback_ftype (enum inferior_event_type event_type,
> void *context);
> "context" is used in several places related to this. OTOH the only
> non-NULL function pointer ever passed to to_async is
> 'inferior_event_handler', which names the second argument "client_data".
> I found them equally clear; particularly once I noticed that all
> existing calls pass context==NULL :)
That looks good to me, thank you!
> As for documentation, I think the docs should be comments before each
> to_* method.
That works for me.
> target.h has been laxly maintained in this regard.
We're getting better at this, though :-). I think we generally
understand better the value of providing good documentation.
Thanks, Tom.
--
Joel