This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 28/32] convert to_get_section_table
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 14 Jan 2014 19:30:21 +0000
- Subject: Re: [RFC 28/32] convert to_get_section_table
- Authentication-results: sourceware.org; auth=none
- References: <1389640367-5571-1-git-send-email-tromey at redhat dot com> <1389640367-5571-29-git-send-email-tromey at redhat dot com> <52D58EB9 dot 1030504 at redhat dot com> <87ha96uzus dot fsf at fleche dot redhat dot com>
On 01/14/2014 07:28 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> Looks fine to me.
>>> - struct target_section_table *(*to_get_section_table) (struct
>>> target_ops *);
>>> + struct target_section_table *(*to_get_section_table) (struct
>>> target_ops *)
>>> + TARGET_DEFAULT_RETURN (0);
>
> Pedro> (I noticed now that methods that return a pointer could
> Pedro> say 'TARGET_DEFAULT_RETURN (NULL)' instead of 0. I'm guessing
> Pedro> you wrote 0 in the previous version where TARGET_DEFAULT
> Pedro> would require a digit.)
>
> Yeah. Unfortunately I didn't think of this early enough. I can fix
> this if you like, but unlike other rewrites, I'd prefer to do it as a
> cleanup patch on top. I found the hard way that modifications to these
> lines cause conflicts to bubble up through the entire patch series.
Yeah, please leave it as is. We can always clean up afterwards.
--
Pedro Alves