This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
go32 fix
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 14 Jan 2014 20:31:44 +0000
- Subject: go32 fix
- Authentication-results: sourceware.org; auth=none
- References: <1389640367-5571-1-git-send-email-tromey at redhat dot com>
> Because this touches every target, I built this on many platforms. I
> mostly did build tests because most of the patches are obviously
> semantically neutral.
>
> x86-64 Fedora 18 (native). I built every revision (cumulatively of
> course). Regression tested native and with the native-gdbserver
> target board.
> x86-64 Fedora 18, cross build with Mingw tools. I cross built each
> revision.
> PPC64 Linux (gcc110 in the compile farm). Built each revision both
> normally and with the SPU target enabled.
> AIX (gcc111 in the compile farm).
> NetBSD 5.1 (gcc70 in the compile farm).
I had the cross toolchain handy, so I build the branch for
go32/djgpp (i586-pc-msdosdjgpp). It caught a buglet:
---
gdb/go32-nat.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/gdb/go32-nat.c b/gdb/go32-nat.c
index c42f48a..161e4e7 100644
--- a/gdb/go32-nat.c
+++ b/gdb/go32-nat.c
@@ -262,8 +262,7 @@ static int go32_can_run (struct target_ops *self);
static struct target_ops go32_ops;
static void go32_terminal_init (struct target_ops *self);
static void go32_terminal_inferior (struct target_ops *self);
-static void go32_terminal_ours (struct target_ops *self,
- struct target_ops *self);
+static void go32_terminal_ours (struct target_ops *self);
#define r_ofs(x) (offsetof(TSS,x))
@@ -930,7 +929,7 @@ go32_terminal_inferior (struct target_ops *self)
}
static void
-go32_terminal_ours (struct target_ops *self, struct target_ops *self)
+go32_terminal_ours (struct target_ops *self)
{
/* Switch to cooked mode on the gdb terminal and save the inferior
terminal mode to be restored when it is resumed. */
--
1.7.11.7