This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
- From: Iain Buclaw <ibuclaw at gdcproject dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 16 Jan 2014 17:03:52 +0000
- Subject: Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion
- Authentication-results: sourceware.org; auth=none
- References: <CABOHX+cJ34G1FA240ZdV8xNsn0fqGezDNcu0aY5k7KZ8=X6_jA at mail dot gmail dot com> <871u0h9g41 dot fsf at fleche dot redhat dot com> <CABOHX+eMZD3xky9axEq1dUTznO0QT5k-GK+-0GUE5W60CrCo4Q at mail dot gmail dot com> <CABOHX+d5u_TZKUtp8eYYrryOLVLwBUgjcdB_VrXDUa14OV8=4Q at mail dot gmail dot com> <8738kv7o9y dot fsf at fleche dot redhat dot com> <CABOHX+cjg+JfZT0CsLxwjrojNTy6AK4w+FBDDrfYOPR1gp_SxQ at mail dot gmail dot com> <87ha94ngh3 dot fsf at fleche dot redhat dot com>
On 16 January 2014 14:34, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
>
> Iain> Is there anything else needed to be done from me? Just asking as I
> Iain> noticed a change to the way that requires this patch to be updated.
>
> I wasn't keeping score, but if all the patches are approved, you can
> rebase (our git repository rejects merge commits on master), merge to
> master, and push. If a patch needs any changes during the rebase, you
> can use your judgment -- if it is just a trivial change, post the
> updated patch as an FYI; if it required some work, usually another round
> of review is needed.
>
It's just trivial, see the change you did to set_main_name (sorry in
advanced for long url link)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blobdiff;f=gdb/symtab.c;h=a8073b8ef7e8027566949952b9115631e33a5f5f;hp=5e988c88efceebfbc90192151e57938884ce62ea;hb=9e6c82ad4f55d0ff125721b94fa2191f1cc1000a;hpb=6ef55de768d4ab9065bc92aa00d828212c4af4f0
Regards
Iain