This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 16 Jan 2014 17:21:04 -0200
- Subject: Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags
- Authentication-results: sourceware.org; auth=none
- References: <52D8293B dot 6060701 at ericsson dot com> <52D82EDF dot 5010402 at redhat dot com>
On Thursday, January 16 2014, Pedro Alves wrote:
> On 01/16/2014 06:47 PM, Simon Marchi wrote:
>> +/* Return the appropriate type_flags for the supplied address class.
>> + This function should return 1 if the address class was recognized and
>> + type_flags was set, zero otherwise.
>
> Say true/false instead of 1/zero.
Sorry, but don't you think this is too nitpicking? And is also the
first time I remember seeing such requirement. I myself use "1/zero"
all the time, and I don't think this is an issue at all.
But I don't want to be meta-nitpicking, of course.
--
Sergio