This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3, doc RFA] gdbserver debug_printf+timestamps: main patch
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Doug Evans <dje at google dot com>
- Cc: palves at redhat dot com, yao at codesourcery dot com, gdb-patches at sourceware dot org
- Date: Fri, 17 Jan 2014 09:04:20 +0200
- Subject: Re: [PATCH 3/3, doc RFA] gdbserver debug_printf+timestamps: main patch
- Authentication-results: sourceware.org; auth=none
- References: <yjt2zjnztait dot fsf at ruffy dot mtv dot corp dot google dot com> <52B1842F dot 5020401 at redhat dot com> <21205 dot 55987 dot 69477 dot 892571 at ruffy dot mtv dot corp dot google dot com> <52D81569 dot 3080006 at redhat dot com> <CADPb22SK=YQeOcOdNPXERxXKOT2E64k=pHhw0GBiLj4LQhL-Ag at mail dot gmail dot com> <52D82AD5 dot 7000306 at redhat dot com> <21208 dot 27400 dot 695984 dot 88504 at ruffy dot mtv dot corp dot google dot com> <21208 dot 27945 dot 781450 dot 905336 at ruffy dot mtv dot corp dot google dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Doug Evans <dje@google.com>
> Date: Thu, 16 Jan 2014 15:37:13 -0800
> cc: gdb-patches <gdb-patches@sourceware.org>
>
> Doug Evans writes:
> > v2 is now split into three parts:
> >
> > 1/3 - move ASSERT_FUNCTION to FUNCTION_NAME in common-utils.h
> > 2/3 - create new function delim_string_to_char_ptr_vec_append in gdb_vecs.c
> > 3/3 - the actual debug_printf patch
> >
> > I went with --debug[=timestamp] as the option naming.
Thanks.
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,11 @@
>
> *** Changes since GDB 7.7
>
> +* New features in the GDB remote stub, GDBserver
> +
> + ** GDBserver now takes an optional argument to --debug, --debug=timestamp,
> + that adds a timestamp with each debugging message.
^^^^^^^^^^^^^^^^^^^^^
Either "adds to" or "prints with" or "includes with".
The documentation parts are OK with that change.