This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] gdb: xtensa: fix linux ptrace includes
- From: Pedro Alves <palves at redhat dot com>
- To: Baruch Siach <baruch at tkos dot co dot il>
- Cc: gdb-patches at sourceware dot org, Maxim Grigoriev <maxim2405 at gmail dot com>, Marc Gauthier <marc at cadence dot com>, Dror Maydan <maydan at cadence dot com>, Woody LaRue <larue at cadence dot com>, Chris Zankel <chris at zankel dot net>
- Date: Mon, 20 Jan 2014 11:50:04 +0000
- Subject: Re: [PATCH v2] gdb: xtensa: fix linux ptrace includes
- Authentication-results: sourceware.org; auth=none
- References: <b244a41787db2076a979c4e18532e51ffc47bb58 dot 1390117992 dot git dot baruch at tkos dot co dot il>
On 01/19/2014 07:53 AM, Baruch Siach wrote:
> Currently, xtensa code using the Linux ptrace interface only include
> sys/ptrace.h. This file comes from the C library (glibc and uClibc, at least),
> and includes a declaration of the ptrace() functions, along with some cross
> architecture constants that are mostly copied from the file located at
> include/uapi/linux/ptrace.h in recent Linux kernels.
>
> For xtensa specific constants like PTRACE_GETXTREGS and PTRACE_SETXTREGS the
> asm/ptrace.h include from the Linux kernel UAPI is needed. The code in
> gdbserver xtensa specific part doesn't call ptrace() directly, so we can
> remove the unneeded sys/ptrace.h include. The gdb xtensa specific code needs
> both headers, since it calls ptrace().
>
Pushed, thanks.
--
Pedro Alves