This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Call remote_check_symbols() even if only symbol-file (not file) has been given
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Christian Eggers <ceggers at gmx dot de>
- Cc: gdb-patches at sourceware dot org, Pedro Alves <palves at redhat dot com>, Yao Qi <yao at codesourcery dot com>
- Date: Mon, 3 Feb 2014 06:18:56 +0400
- Subject: Re: [PATCH] Call remote_check_symbols() even if only symbol-file (not file) has been given
- Authentication-results: sourceware.org; auth=none
- References: <3438987 dot Z4RkDDzs8O at p2130>
Hello Christian,
On Sat, Feb 01, 2014 at 08:21:31AM +0100, Christian Eggers wrote:
> The Eclipse "C/C++ GDB Hardware Debugging" plugin runs only
> the "symbol-file" command. In this case, remote_check_symbols()
> is not called and no qSymbol:: packet is sent to the gdbserver
> (OpenOCD in my case).
>
> 2014-02-01 Christian Eggers <ceggers@gmx.de>
>
> * remote.c (remote_start_remote): Call remote_check_symbols() even if only symbol-file (not file) has been given.
With my Patch Champion hat...
The line above in the ChangeLog is too long and needs to be split at
around 70-80 characters.
> diff --git a/gdb/remote.c b/gdb/remote.c
> index 7297df0..40cc143 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -3668,7 +3668,7 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p)
> /* If we connected to a live target, do some additional setup. */
> if (target_has_execution)
> {
> - if (exec_bfd) /* No use without an exec file. */
> + if (symfile_objfile) /* No use without an symbol-file. */
> remote_check_symbols ();
> }
"a symbol-file" (instead of "an")?
--
Joel