This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix building with yacc
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: brobecker at adacore dot com
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 5 Feb 2014 13:37:43 +0100 (CET)
- Subject: Re: [PATCH] Fix building with yacc
- Authentication-results: sourceware.org; auth=none
- References: <201402031351 dot s13DpgDY020084 at glazunov dot sibelius dot xs4all dot nl> <20140205021312 dot GB5485 at adacore dot com>
> Date: Wed, 5 Feb 2014 06:13:12 +0400
> From: Joel Brobecker <brobecker@adacore.com>
>
> Hi Mark,
>
> > OpenBSD yacc doesn't use YYPRINT, so we end up with gcc complaining
> > that c_print_token is defined but not used. As far as I can determine
> > YYPRINT is a bison-ism, so the diff below wraps c_print_token in
> > #ifdef YYBISON.
> >
> > ok?
>
> I don't know bison much to really review the patch, but I think
> that you meant c_print_token to remain static, right? (see below)
> Aside from that, the change looks OK to me.
Oops. Thanks for spotting that. Below is what I ended up committing:
>From 12c5175d68a840960e4cf7d3001c926f15c4d006 Mon Sep 17 00:00:00 2001
From: Mark Kettenis <kettenis@gnu.org>
Date: Wed, 5 Feb 2014 13:30:33 +0100
Subject: [PATCH] Avoid bison-isms when using yacc.
YYPRINT is a bison-ism so c_print_token() ends up being unused when yacc is
used which makes gcc unhappy. Make sure we only define YYPRINT and
c_print_token() when bison is used to generate the parser.
gdb/ChangeLog:
* c-exp.y (YYPRINT, c_print_token): Only define if YYBISON is
defined.
---
gdb/ChangeLog | 5 +++++
gdb/c-exp.y | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a6fa6fc..fcec355 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2014-02-05 Mark Kettenis <kettenis@gnu.org>
+
+ * c-exp.y (YYPRINT, c_print_token): Only define if YYBISON is
+ defined.
+
2014-02-05 Yao Qi <yao@codesourcery.com>
* remote.c (remote_pass_signals): Remove local 'buf' and use
diff --git a/gdb/c-exp.y b/gdb/c-exp.y
index 277242e..4704845 100644
--- a/gdb/c-exp.y
+++ b/gdb/c-exp.y
@@ -169,8 +169,10 @@ static struct stoken operator_stoken (const char *);
static void check_parameter_typelist (VEC (type_ptr) *);
static void write_destructor_name (struct stoken);
+#ifdef YYBISON
static void c_print_token (FILE *file, int type, YYSTYPE value);
#define YYPRINT(FILE, TYPE, VALUE) c_print_token (FILE, TYPE, VALUE)
+#endif
%}
%type <voidval> exp exp1 type_exp start variable qualified_name lcurly
@@ -3201,6 +3203,8 @@ c_parse (void)
return result;
}
+#ifdef YYBISON
+
/* This is called via the YYPRINT macro when parser debugging is
enabled. It prints a token's value. */
@@ -3255,6 +3259,8 @@ c_print_token (FILE *file, int type, YYSTYPE value)
}
}
+#endif
+
void
yyerror (char *msg)
{
--
1.8.5.3