This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC v2 07/38] Add target_ops argument to to_close
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 10 Feb 2014 10:50:14 -0700
- Subject: Re: [RFC v2 07/38] Add target_ops argument to to_close
- Authentication-results: sourceware.org; auth=none
- References: <1391720136-2121-1-git-send-email-tromey at redhat dot com> <1391720136-2121-8-git-send-email-tromey at redhat dot com> <52F59D5B dot 2040308 at codesourcery dot com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> /* Fetch the AT_HWCAP entry from the aux vector. */
Yao> static unsigned long
Yao> ppc_linux_get_hwcap (void)
Yao> {
Yao> CORE_ADDR field;
Yao> if (target_auxv_search (¤t_target, AT_HWCAP, &field))
Yao> return (unsigned long) field;
Yao> return 0;
Yao> }
Yao> Do we need to add argument 'ops' to ppc_linux_get_hwcap and stop
Yao> using current_target in ppc_linux_get_hwcap?
It depends on whether the call should act at the current stratum or
below, or whether the call should restart from the top of the target
stack.
In most cases I think the latter is intended.
Yao> You may have done that in the following patches, and it is not
Yao> surprise I miss it.
Nope.
Tom