This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 4/8] Let tracefile has_memory and has_all_memory.
- From: Yao Qi <yao at codesourcery dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Wed, 12 Feb 2014 14:05:48 +0800
- Subject: [PATCH 4/8] Let tracefile has_memory and has_all_memory.
- Authentication-results: sourceware.org; auth=none
- References: <1392185152-21220-1-git-send-email-yao at codesourcery dot com>
At present, tfile target thinks it has memory but ctf doesn't.
This is an oversight when I added ctf target support. This patch
moves the implementations of to_has_all_memory and to_has_memory to
upper layer. After this change, both tfile and ctf target think
they have memory.
gdb:
2014-02-122 Yao Qi <yao@codesourcery.com>
* tracefile-tfile.c (tfile_has_all_memory): Remove.
(tfile_has_memory): Remove.
(init_tfile_ops): Don't set fields to_has_all_memory and
to_has_memory of tfile_ops.
* tracefile.c (tracefile_has_all_memory): New function.
(tracefile_has_memory): New function.
(init_tracefile_ops): Initialize fields to_has_all_memory and
to_has_memory of 'ops'.
---
gdb/tracefile-tfile.c | 14 --------------
gdb/tracefile.c | 18 ++++++++++++++++++
2 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/gdb/tracefile-tfile.c b/gdb/tracefile-tfile.c
index 205494e..80df960 100644
--- a/gdb/tracefile-tfile.c
+++ b/gdb/tracefile-tfile.c
@@ -1006,18 +1006,6 @@ tfile_get_trace_state_variable_value (int tsvnum, LONGEST *val)
return found;
}
-static int
-tfile_has_all_memory (struct target_ops *ops)
-{
- return 1;
-}
-
-static int
-tfile_has_memory (struct target_ops *ops)
-{
- return 1;
-}
-
/* Callback for traceframe_walk_blocks. Builds a traceframe_info
object for the tfile target's current traceframe. */
@@ -1099,8 +1087,6 @@ init_tfile_ops (void)
tfile_ops.to_trace_find = tfile_trace_find;
tfile_ops.to_get_trace_state_variable_value
= tfile_get_trace_state_variable_value;
- tfile_ops.to_has_all_memory = tfile_has_all_memory;
- tfile_ops.to_has_memory = tfile_has_memory;
tfile_ops.to_traceframe_info = tfile_traceframe_info;
}
diff --git a/gdb/tracefile.c b/gdb/tracefile.c
index 0f8ffc5..a2dc9fd 100644
--- a/gdb/tracefile.c
+++ b/gdb/tracefile.c
@@ -376,6 +376,22 @@ trace_save_ctf (const char *dirname, int target_does_save)
do_cleanups (back_to);
}
+/* This is the implementation of target_ops method to_has_all_memory. */
+
+static int
+tracefile_has_all_memory (struct target_ops *ops)
+{
+ return 1;
+}
+
+/* This is the implementation of target_ops method to_has_memory. */
+
+static int
+tracefile_has_memory (struct target_ops *ops)
+{
+ return 1;
+}
+
/* This is the implementation of target_ops method to_has_stack.
The target has a stack when GDB has already selected one trace
frame. */
@@ -424,6 +440,8 @@ init_tracefile_ops (struct target_ops *ops)
{
ops->to_stratum = process_stratum;
ops->to_get_trace_status = tracefile_get_trace_status;
+ ops->to_has_all_memory = tracefile_has_all_memory;
+ ops->to_has_memory = tracefile_has_memory;
ops->to_has_stack = tracefile_has_stack;
ops->to_has_registers = tracefile_has_registers;
ops->to_thread_alive = tracefile_thread_alive;
--
1.7.7.6