This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH 1/2] nios2-tdep: set default frame base
- From: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>
- To: 'Yao Qi' <yao at codesourcery dot com>
- Cc: "sandra at codesourcery dot com" <sandra at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 12 Feb 2014 10:04:19 +0000
- Subject: RE: [PATCH 1/2] nios2-tdep: set default frame base
- Authentication-results: sourceware.org; auth=none
- References: <1392110775-21242-1-git-send-email-sanimir dot agovic at intel dot com> <1392110775-21242-2-git-send-email-sanimir dot agovic at intel dot com> <52FACC71 dot 8090407 at codesourcery dot com>
Thanks Yao. Is it OK to commit both patches? Below the updated patch.
nios2-tdep: remove unreferenced global nios2_stub_frame_base
2014-02-11 Sanimir Agovic <sanimir.agovic@intel.com>
* nios2-tdep.c (nios2_stub_frame_base): Remove global.
diff --git a/gdb/nios2-tdep.c b/gdb/nios2-tdep.c
index 8f18739..ca653f7 100644
--- a/gdb/nios2-tdep.c
+++ b/gdb/nios2-tdep.c
@@ -1354,14 +1354,6 @@ static const struct frame_unwind nios2_stub_frame_unwind =
nios2_stub_frame_sniffer
};
-static const struct frame_base nios2_stub_frame_base =
-{
- &nios2_stub_frame_unwind,
- nios2_stub_frame_base_address,
- nios2_stub_frame_base_address,
- nios2_stub_frame_base_address
-};
-
/* Helper function to read an instruction at PC. */
static unsigned long
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf
> Of Yao Qi
> Sent: Wednesday, February 12, 2014 02:21 AM
> To: Agovic, Sanimir
> Cc: sandra@codesourcery.com; gdb-patches@sourceware.org
> Subject: Re: [PATCH 1/2] nios2-tdep: set default frame base
>
> On 02/11/2014 05:26 PM, Sanimir Agovic wrote:
> > @@ -1595,6 +1595,7 @@ nios2_gdbarch_init (struct gdbarch_info info, struct gdbarch_list
> *arches)
> > dwarf2_append_unwinders (gdbarch);
> > frame_unwind_append_unwinder (gdbarch, &nios2_stub_frame_unwind);
> > frame_unwind_append_unwinder (gdbarch, &nios2_frame_unwind);
> > + frame_base_set_default (gdbarch, &nios2_stub_frame_base);
>
> Sanimir,
> some lines below, we have:
>
> frame_unwind_append_unwinder (gdbarch, &nios2_frame_unwind);
>
> /* Single stepping. */
> set_gdbarch_software_single_step (gdbarch, nios2_software_single_step);
>
> /* Hook in ABI-specific overrides, if they have been registered. */
> gdbarch_init_osabi (info, gdbarch);
>
> if (tdep->jb_pc >= 0)
> set_gdbarch_get_longjmp_target (gdbarch, nios2_get_longjmp_target);
>
> frame_base_set_default (gdbarch, &nios2_frame_base);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> so looks we can remove nios2_stub_frame_base.
>
> --
> Yao (éå)
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052