This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/7] procfs.c: Don't install a deprecated_xfer_memory method
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 20 Feb 2014 16:38:30 +0000
- Subject: Re: [PATCH 3/7] procfs.c: Don't install a deprecated_xfer_memory method
- Authentication-results: sourceware.org; auth=none
- References: <1392841775-19126-1-git-send-email-palves at redhat dot com> <1392841775-19126-4-git-send-email-palves at redhat dot com> <20140220154826 dot GD4113 at adacore dot com> <20140220155611 dot GA17210 at adacore dot com>
On 02/20/2014 03:56 PM, Joel Brobecker wrote:
>>> gdb/
>>> 2014-02-19 Pedro Alves <palves@redhat.com>
>>>
>>> * procfs.c (procfs_target): Don't install procfs_xfer_memory as
>>> deprecated_xfer_memory hook.
>>> (procfs_xfer_partial): Call procfs_xfer_memory instead
>>> of the deprecated_xfer_memory target hook.
>>> (procfs_xfer_memory): Adjust interface as a to_xfer_partial
>>> helper.
>>
>> FYI: I tried to test it, but the sparc-solaris debugger appears to be
>> badly broken at the moment, and I won't have much time left this week
>> to investigate the failures, so I'll schedule that for next week.
Thanks.
>
> I forgot to attach a small patch that fixes a build failure because
> of a declaration that no longer matches the definition...
Thanks! I'll merge that in.
> After your patch, we could probably avoid the need for this declaration
> by swapping two functions, but for another day.
Yeah.
--
Pedro Alves