This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] linux-low.c (add_lwp): Change result to struct lwp_info *.
- From: Doug Evans <dje at google dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 20 Feb 2014 13:24:30 -0800
- Subject: [commit] linux-low.c (add_lwp): Change result to struct lwp_info *.
- Authentication-results: sourceware.org; auth=none
- References: <yjt2lhxyd4ii dot fsf at ruffy dot mtv dot corp dot google dot com>
Doug Evans writes:
> Hi.
> This is the main patch.
> The concept is very simple: remove all_lwps.
> I think it's the right thing to do, I can't think of a good reason
> to maintain two separate lists of threads, each containing a subset
> of the data needed.
>
> Alas implementing this involves a lot of work.
I split this patch out.
Committed.
2014-02-19 Doug Evans <dje@google.com>
* linux-low.c (add_lwp): Change result to struct lwp_info *.
All callers updated.
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index 2a83022..910d96d 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -226,7 +226,7 @@ static void linux_resume (struct thread_resume *resume_info, size_t n);
static void stop_all_lwps (int suspend, struct lwp_info *except);
static void unstop_all_lwps (int unsuspend, struct lwp_info *except);
static int linux_wait_for_event (ptid_t ptid, int *wstat, int options);
-static void *add_lwp (ptid_t ptid);
+static struct lwp_info *add_lwp (ptid_t ptid);
static int linux_stopped_by_watchpoint (void);
static void mark_lwp_dead (struct lwp_info *lwp, int wstat);
static void proceed_all_lwps (void);
@@ -408,7 +408,7 @@ handle_extended_wait (struct lwp_info *event_child, int wstat)
}
ptid = ptid_build (pid_of (event_child), new_pid, 0);
- new_lwp = (struct lwp_info *) add_lwp (ptid);
+ new_lwp = add_lwp (ptid);
add_thread (ptid, new_lwp);
/* Either we're going to immediately resume the new thread
@@ -525,7 +525,7 @@ get_stop_pc (struct lwp_info *lwp)
return stop_pc;
}
-static void *
+static struct lwp_info *
add_lwp (ptid_t ptid)
{
struct lwp_info *lwp;
@@ -682,7 +682,7 @@ linux_attach_lwp_1 (unsigned long lwpid, int initial)
ptid = ptid_build (pid, lwpid, 0);
}
- new_lwp = (struct lwp_info *) add_lwp (ptid);
+ new_lwp = add_lwp (ptid);
add_thread (ptid, new_lwp);
/* We need to wait for SIGSTOP before being able to make the next