This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix length arg in call to breakpoint_xfer_memory
- From: Pedro Alves <palves at redhat dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, Ulrich Weigand <uweigand at de dot ibm dot com>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, Yao Qi <yao at codesourcery dot com>
- Date: Fri, 21 Feb 2014 13:56:25 +0000
- Subject: Re: [PATCH] Fix length arg in call to breakpoint_xfer_memory
- Authentication-results: sourceware.org; auth=none
- References: <87ios8fwf9 dot fsf at br87z6lw dot de dot ibm dot com>
On 02/21/2014 01:05 PM, Andreas Arnez wrote:
> The patch "return target_xfer_status in to_xfer_partial" caused a
> regression in various s390(x) test cases, because memory_xfer_partial
> filled only the first byte of the read buffer from a breakpoint shadow:
Ah. Breakpoints on x86 happen to be 1 byte long. How lucky. :-)
>
> https://sourceware.org/ml/gdb-patches/2014-01/msg01071.html
>
> This patch fixes the regression.
>
> ChangeLog/
> * target.c (memory_xfer_partial): Fix length arg in call to
> breakpoint_xfer_memory.
OK.
Thanks,
--
Pedro Alves