This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/DWARF] constant class of DW_AT_high_pc is offset for version >=4 only.
- From: Mark Wielaard <mjw at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 26 Feb 2014 11:53:25 +0100
- Subject: Re: [RFA/DWARF] constant class of DW_AT_high_pc is offset for version >=4 only.
- Authentication-results: sourceware.org; auth=none
- References: <1392478818-30320-1-git-send-email-brobecker at adacore dot com> <20140218133000 dot GA15835 at adacore dot com> <1392739369 dot 21975 dot 145 dot camel at bordewijk dot wildebeest dot org> <20140218184906 dot GB15835 at adacore dot com> <1392760350 dot 21975 dot 200 dot camel at bordewijk dot wildebeest dot org> <20140219072317 dot GA4270 at adacore dot com> <1392817469 dot 21975 dot 221 dot camel at bordewijk dot wildebeest dot org> <20140221184227 dot GC4720 at adacore dot com>
On Fri, 2014-02-21 at 19:42 +0100, Joel Brobecker wrote:
> Attached is the latest version of the patch.
>
> I implemented the complaint, and then reverted it, for reasons that
> I explained in the added comment inside the new attr_value_as_address
> function. Basically, I don't want to be doing extra work as well as
> pessimize this function's number of arguments just for a very rare
> case of broken compiler.
Obviously I would like lots of screaming and yelling here (and the
function/argument will probably be inlined anyway, so I don't think the
extra argument passing will actually hurt that much, but that is
speculation). I do understand gdb isn't a DWARF-linter, and how you do
things is more in line with the "be liberal in what you accept"
principle.
No complaints (pun intended) to this patch.
Cheers,
Mark