This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/3] windows: Factorize handling of DLL load address offset
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 26 Feb 2014 18:30:26 +0000
- Subject: Re: [RFA 2/3] windows: Factorize handling of DLL load address offset
- Authentication-results: sourceware.org; auth=none
- References: <1393284074-9889-1-git-send-email-brobecker at adacore dot com> <1393284074-9889-3-git-send-email-brobecker at adacore dot com>
On 02/24/2014 11:21 PM, Joel Brobecker wrote:
> This patch is a small cleanup that moves the magic 0x1000 offset
> to apply to a DLL's base address inside the win32_add_one_solib
> function, rather than delegate that reponsibility to its callers.
>
Looks good, thanks.
GDBserver is trailing GDB in this magic 0x1000 handling, see:
https://sourceware.org/bugzilla/show_bug.cgi?id=15046
--
Pedro Alves