This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 2/3] windows: Factorize handling of DLL load address offset


On 02/24/2014 11:21 PM, Joel Brobecker wrote:
> This patch is a small cleanup that moves the magic 0x1000 offset
> to apply to a DLL's base address inside the win32_add_one_solib
> function, rather than delegate that reponsibility to its callers.
> 

Looks good, thanks.

GDBserver is trailing GDB in this magic 0x1000 handling, see:

 https://sourceware.org/bugzilla/show_bug.cgi?id=15046

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]