This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR 12702 - gdb can hang waiting for thread group leader (gdbserver)
- From: Pedro Alves <palves at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Hui Zhu <teawater at gmail dot com>, gdb-patches ml <gdb-patches at sourceware dot org>, "Gustavo, Luis" <luis_gustavo at mentor dot com>
- Date: Thu, 27 Feb 2014 14:38:19 +0000
- Subject: Re: [PATCH] Fix PR 12702 - gdb can hang waiting for thread group leader (gdbserver)
- Authentication-results: sourceware.org; auth=none
- References: <CANFwon2cWyxzWi+Sqfk6mUK0ZCWQRisMmGWe6mxPMgDLTV_j2g at mail dot gmail dot com> <51F01C13 dot 3080402 at redhat dot com> <CANFwon2jf-d8RNN3wScXZDe7ETm=rQ5CyOY723XLegpgFVb3XQ at mail dot gmail dot com> <52E12075 dot 3040601 at redhat dot com>
On 01/23/2014 02:00 PM, Pedro Alves wrote:
> This is main gripe with this patch. I'd really like to avoid
> bringing in more of this broken use of waitpid(PID) into gdbserver
> (I realize most of this is copied from GDB), and this duplication
> of low level wait status handling. I think we can do
> better in gdbserver. There's really no need for wait_for_sigstop
> to wait for each LWP in turn. I think that with some
> refactoring, we can make it reuse linux_wait_for_event, and
> only end up with having to handle pending statuses in one place.
>
> So I've been working on this most of this week, and I got this
> almost done but I'm afraid I'll need to give attention to other
> work, so I'm not sure I'll be able to be back at this before
> February. Anyway, I'll post a WIP series in response to this email.
I've now rebased this on current mainline, wrote ChangeLogs, etc.
and pushed it.
https://sourceware.org/ml/gdb-patches/2014-02/msg00826.html
> In addition, it goes a step forward and starts adding support for
> TARGET_WAITKIND_NO_RESUMED to the RSP as well, which is needed for
> fully fixing no-unwaited-for-left.exp.
I didn't get to finish that one yet, so I've left it out for now.
--
Pedro Alves