Re: [patchv3 1/8] Move utility functions to common/

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Fri, 28 Feb 2014 13:06:22 +0100, Pedro Alves wrote:
> On 02/27/2014 09:32 PM, Jan Kratochvil wrote:
> > 	(hex2bin, bin2hex): Move decls from remote.h.
> 
> This one looks stale.

Yes, removed.


> > --- a/gdb/common/common-utils.h
> > +++ b/gdb/common/common-utils.h
> > @@ -25,6 +25,25 @@
> >  #include <stddef.h>
> >  #include <stdarg.h>
> >  
> > +/* Static target-system-dependent parameters for GDB.  */
> > +
> > +/* * Number of bits in a char or unsigned char for the target machine.
> > +   Just like CHAR_BIT in <limits.h> but describes the target machine.  */
> > +#if !defined (TARGET_CHAR_BIT)
> > +#define TARGET_CHAR_BIT 8
> > +#endif
> > +
> > +/* * If we picked up a copy of CHAR_BIT from a configuration file
> > +   (which may get it by including <limits.h>) then use it to set
> 
> Sounds like common-utils.h should include limits.h?  defs.h does
> include it.

Primarily TARGET_CHAR_BIT and HOST_CHAR_BIT are obsolete, already C90 defines
CHAR_BIT as constant 8.

IIRC there was a discussion GDB could replace these macros by the number 8,
simplifying a lot of code.  Although IIRC there was agreement only on
HOST_CHAR_BIT, that TARGET_CHAR_BIT may possibly differ in some cases
(I do not believe it now, though).  But I do not have the mail reference now.

I have added <limits.h> there when the text references it.


> > +   the number of bits in a host char.  If not, use the same size
> > +   as the target.  */
> > +
> > +#if defined (CHAR_BIT)
> > +#define HOST_CHAR_BIT CHAR_BIT
> > +#else
> > +#define HOST_CHAR_BIT TARGET_CHAR_BIT
> > +#endif
> 
> I think host-defs.h might be a better home for this.  (With the
> target version placed in a new target-defs.h perhaps.  I won't
> insist though.)

But I am not going to create new files because of an obsolete macro which
should be in the first place deleted.


Thanks,
Jan