This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/6] Fix missing breakpoing/watchpoint hits, eliminate deferred_step_ptid.
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 05 Mar 2014 16:09:57 +0000
- Subject: Re: [PATCH 3/6] Fix missing breakpoing/watchpoint hits, eliminate deferred_step_ptid.
- Authentication-results: sourceware.org; auth=none
- References: <1393360363-5603-1-git-send-email-palves at redhat dot com> <1393360363-5603-4-git-send-email-palves at redhat dot com> <53156C94 dot 40009 at codesourcery dot com>
On 03/04/2014 06:03 AM, Yao Qi wrote:
> I don't have much comments on the patch, just some nits on tests:
>
> On 02/26/2014 04:32 AM, Pedro Alves wrote:
>> + gdb_test "set scheduler-locking off"
>
> Use "gdb_test_no_output"?
>
>> + gdb_test "info breakpoints"
>> + gdb_test "set debug infrun 1"
>
> I don't see the purpose of doing these two tests.
It was handy to have them there while working on the patch,
and I forgot to remove them.
>
> They apply to step-over-lands-on-watchpoint.exp too.
>
Fixed in v2.
Thanks!
--
Pedro Alves