This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4] gdb.exp: Support absolute path name args in 'prepare_for_testing' etc.


Andreas Arnez wrote:

> Test cases that produce source files in the build directory have not
> been able to use prepare_for_testing and friends.  This was because
> build_executable_from_specs unconditionally prepended the source
> directory path name to its arguments.
> 
> gdb/testsuite/
> 	* lib/gdb.exp (build_executable_from_specs): Don't prepend source
> 	directory to absolute path name arguments.

I think that makes sense, and there is precedent to this approach in
gdb_get_line_number and mi_prepare_inline_tests.

However, for consistency, I think you should also support absolute
path names in the gdb_compile_shlib[_pthreads] path just next to
the location you're modifying.

Otherwise this looks good to me.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]