This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][PR/backtrace 16721] Fix erroneous backtrace on AVR
- From: Pierre Langlois <pierre dot langlois at embecosm dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 21 Mar 2014 13:23:07 +0000
- Subject: Re: [PATCH][PR/backtrace 16721] Fix erroneous backtrace on AVR
- Authentication-results: sourceware.org; auth=none
- References: <53288819 dot 7080903 at embecosm dot com> <20140319123423 dot GF4282 at adacore dot com>
Hi Joel,
Sorry for the late reply.
Now that Tristan approved the patch, do you have an FSF copyright
assignment on file? This patch is small that we can push it in without;
but if you are planning on sending more, you'll need one. Just let me
know and I will get you a message to get you started (it takes a while
to complete, so the sooner the better).
I am doing this work on behalf of Embecosm, we have an FSF copyright assignment
on file.
One remark on the ChangeLog; the formatting is off a bit. It should be
indented by one tab, and the indentation should be the same, regardless
of whether the line starts with a '*' or not - no extra indentation
for continuation lines. Thus:
* avr-tdep.c (avr_scan_prologue): Accept push r1 instruction for small
stack allocation.
(in emails, it's not important to be using 8 spaces or 1 tab, but in
the CL, we tend to be picky about it).
I'll make sure my email client is properly configured next time.
Thank you very much!
Pierre