This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Check file exists before completion tests


On 04/02/2014 12:51 PM, Yao Qi wrote:
> Doug told me that there are some regressions in gdb.base/completion.exp.
> They are caused by my recent change, and can be reproduced via:
> 
> $ make check-parallel TESTS=gdb.base/completion.exp
> FAIL: gdb.base/completion.exp: complete target core ./gdb.base/completion
> FAIL: gdb.base/completion.exp: complete target tfile ./gdb.base/completion
> FAIL: gdb.base/completion.exp: complete target exec ./gdb.base/completion
> 
> Current tests assume that gdb.base/completion exists but that is wrong
> in a parallel run, because binary file and object files are placed
> in outputs/gdb.base/completion/.
> 
> This patch is to check file exists on two candidate directories,
> "gdb.base" and "outputs/gdb.base/completion/", and run tests with files
> existed in either of them.
> 
> OK?
> 
> gdb/testsuite:
> 
> 2014-04-02  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.base/completion.exp: Check file exists before running tests
> 	on file completion.

Ping.  https://sourceware.org/ml/gdb-patches/2014-04/msg00019.html

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]