This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] add return values to return statements in non-void functions
- From: Doug Evans <dje at google dot com>
- To: David Blaikie <dblaikie at gmail dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 23 Apr 2014 17:23:21 -0700
- Subject: Re: [patch] add return values to return statements in non-void functions
- Authentication-results: sourceware.org; auth=none
- References: <CAENS6Ev9CdJBUt9JaFtsroSD=gC3OfnHFYBdd=hPENWGCxv8SA at mail dot gmail dot com>
David Blaikie writes:
> These missing return values cause build breaks with clang which
> defaults the -Wreturn-type warning to an error in this case.
>
> Add the right return values so these tests can run when using clang.
> commit ce1534e51863af5d935cdc63c44df0fa64a46653
> Author: David Blaikie <dblaikie@gmail.com>
> Date: Fri Apr 11 17:20:49 2014 -0700
>
> Add return value for non-void function return statements to fix error in clang build.
>
> Clang defaults this warning to an error, breaking the build & causing
> these tests not to run.
>
> gdb/testsuite/
>
> * gdb.mi/non-stop.c: Add return value for non-void function return
> statement.
> * gdb.threads/staticthreads.c: Ditto.
ChangeLog rules require being more specific about where the change happened.
E.g.,
* gdb.mi/non-stop.c (worker): Add return value for non-void function
return statement.
* gdb.threads/staticthreads.c (thread_function): Ditto.
Ok with those changes.
Thanks!