This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 09/12] Delete varobj's children on traceframe is changed.


On 02/14/2014 12:44 AM, Yao Qi wrote:
  V2:
  - Move common code to varobj_clear_children.
  - Update comments.

gdb:

2014-02-14  Yao Qi  <yao@codesourcery.com>

	* varobj.c: Include "observer.h".
	(varobj_clear_children): New functiuon.
	(varobj_set_available_children_only): Move some code to
	varobj_clear_children.  Call varobj_clear_children.
	(varobj_delete_if_available_children_only): New function.
	(varobj_traceframe_changed): New function.
	(_initialize_varobj): Install varobj_traceframe_changed to
	traceframe_changed observer.

This looks okay to me. I recommend a maintainer give this a final review.

Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]