This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 09/12] Delete varobj's children on traceframe is changed.
- From: Keith Seitz <keiths at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Thu, 24 Apr 2014 13:45:31 -0700
- Subject: Re: [PATCH 09/12] Delete varobj's children on traceframe is changed.
- Authentication-results: sourceware.org; auth=none
- References: <1392367471-13527-1-git-send-email-yao at codesourcery dot com> <1392367471-13527-10-git-send-email-yao at codesourcery dot com>
On 02/14/2014 12:44 AM, Yao Qi wrote:
V2:
- Move common code to varobj_clear_children.
- Update comments.
gdb:
2014-02-14 Yao Qi <yao@codesourcery.com>
* varobj.c: Include "observer.h".
(varobj_clear_children): New functiuon.
(varobj_set_available_children_only): Move some code to
varobj_clear_children. Call varobj_clear_children.
(varobj_delete_if_available_children_only): New function.
(varobj_traceframe_changed): New function.
(_initialize_varobj): Install varobj_traceframe_changed to
traceframe_changed observer.
This looks okay to me. I recommend a maintainer give this a final review.
Keith