This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 6/9] Remove Guile GDB object property mechanism


Andy Wingo <wingo@igalia.com> writes:

> gdb/ChangeLog:
> 	* guile/guile-internal.h (scm_gsmob, GDB_SMOB_HEAD) Remove base
> 	type; it only served as something to which object properties could
> 	be attached: a use case already served by Guile's own object
> 	properties.  Remove from all subtypes.
> 	(gdbscm_init_gsmob, gdbscm_mark_gsmob, gdbscm_mark_chained_gsmob)
> 	(gdbscm_mark_eqable_gsmob): Remove these now-unneeded functions.
> 	Adapt all callers.

I can let go of gdb-object properties,
but GDB_SMOB_HEAD was really useful during development.
C doesn't support empty structs, but I wish to keep GDB_SMOB_HEAD.
It can consist of "int empty_base_class;" or some such for now.

> 	* guile/scm-gsmob.c (gdbscm_init_gsmob, gdbscm_mark_gsmob)
> 	(gdbscm_mark_chained_gsmob, gdbscm_mark_eqable_gsmob): Remove.
> 	(gdbscm_gsmob_property, gdbscm_set_gsmob_property_x)
> 	(gdbscm_gsmob_has_property_p, add_property_name)
> 	(gdbscm_gsmob_properties): Remove these public interfaces, and
> 	remove them from gsmob_functions.
>
> 	* guile/lib/gdb.scm (gdb-object-property, set-gdb-object-property)
> 	(gdb-object-has-property?, gdb-object-properties): Remove.

No blank lines between related changelog entries.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]