[PATCH] gdbserver: constify the 'pid_to_exec_file' target op

Aktemur, Tankut Baris tankut.baris.aktemur@intel.com
Mon Apr 12 14:38:05 GMT 2021


On Monday, April 12, 2021 4:10 PM, Simon Marchi wrote:
> On 2021-04-12 8:30 a.m., Tankut Baris Aktemur via Gdb-patches wrote:
> > diff --git a/gdbserver/server.cc b/gdbserver/server.cc
> > index 2a443305691..156fd4333df 100644
> > --- a/gdbserver/server.cc
> > +++ b/gdbserver/server.cc
> > @@ -1466,7 +1466,7 @@ handle_qxfer_exec_file (const char *annex,
> >  			gdb_byte *readbuf, const gdb_byte *writebuf,
> >  			ULONGEST offset, LONGEST len)
> >  {
> > -  char *file;
> > +  const char *file;
> 
> Since you are touching this, let's move the declaration to where the
> assignment is done.
> 
> Otherwise, LGTM, thanks.
> 
> Simon

Pushed with that change.  Thanks.

-Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


More information about the Gdb-patches mailing list