[PATCH v2 3/3] Guile: add value-const-value

Eli Zaretskii eliz@gnu.org
Tue Apr 27 13:57:31 GMT 2021


> Date: Tue, 27 Apr 2021 05:36:27 +1000
> From: George Barrett via Gdb-patches <gdb-patches@sourceware.org>
> Cc: George Barrett <bob@bob131.so>
> 
> The Guile API doesn't currently have an equivalent to the Python API's
> gdb.Value.const_value(). This commit adds a procedure with equivalent
> semantics to the Guile API.
> 
> gdb/ChangeLog:
> 
> 2021-04-27  George Barrett  <bob@bob131.so>
> 
> 	* guile/scm-value.c (gdbscm_value_const_value): Add
> 	implementation of value-const-value procedure.
> 	(value_functions): Add value-const-value procedure.
> 
> gdb/doc/ChangeLog:
> 
> 2021-04-27  George Barrett  <bob@bob131.so>
> 
> 	* guile.texi (Values From Inferior In Guile): Add
> 	documentation for value-const-value.
> 
> gdb/testsuite/ChangeLog:
> 
> 2021-04-27  George Barrett  <bob@bob131.so>
> 
> 	* gdb.guile/scm-value.exp (test_value_in_inferior): Add test
> 	for value-const-value.

Thanks.

> +@deffn {Scheme Procedure} value-const-value value
> +Return a new @code{<gdb:value>} object which is a 'const' version of
                                                     ^^^^^^^
Please use @samp{const} instead.  In general, ASCII quotes are almost
never correct in Texinfo.

> +@code{<gdb:value>} object @var{value}.

Can you tell me what is the significance of the brackets <..> here?  I
see it is used elsewhere in the manual, but I'm not sure it isn't a
mistake.

Other than that, the patch for the manual is okay.


More information about the Gdb-patches mailing list