[PATCH] GDB: Fix test case gdb.base/valgrind-bt.exp.

Tom de Vries tdevries@suse.de
Thu Apr 29 11:28:55 GMT 2021


On 4/19/21 11:22 PM, Carl Love via Gdb-patches wrote:
> diff --git a/gdb/testsuite/lib/valgrind.exp b/gdb/testsuite/lib/valgrind.exp
> index c214491f7b8..caabeda9730 100644
> --- a/gdb/testsuite/lib/valgrind.exp
> +++ b/gdb/testsuite/lib/valgrind.exp
> @@ -82,12 +82,15 @@ proc vgdb_start { {active_at_startup 1} } {
>  
>      clean_restart $testfile
>  
> +    set vgdbcmd "set remotetimeout 3"
> +
>      # Make sure we're disconnected, in case we're testing with the
>      # native-extended-gdbserver board, where gdb_start/gdb_load spawn
>      # gdbserver and connect to it.
>      gdb_test "disconnect" ".*"
>  
> -    set vgdbcmd "target remote | vgdb --wait=1 --pid=$vgdbpid"
> +    set vgdbcmd "target remote | vgdb --wait=2 --max-invoke-ms=2500 --pid=$vgdbpid"
> +
>      if { $active_at_startup } {
>  	gdb_test "$vgdbcmd" " in \\.?_start .*" "target remote for vgdb"
>      } else {
> 

AFAICT, the first "set vgdbcmd" doesn't achieve anything.

The value is overwritten by the second "set vgdbcmd".

Thanks,
- Tom


More information about the Gdb-patches mailing list