[gdb/testsuite] Fix timeout in gdb.base/valgrind-infcall-2.exp

[Keith Seitz]

On 4/29/21 6:57 AM, Tom de Vries wrote:
> [ was: Re: [PATCH] GDB: Fix test case gdb.base/valgrind-bt.exp. ]
> 
> On 4/29/21 1:46 PM, Tom de Vries wrote:
>> On 4/29/21 1:28 PM, Tom de Vries wrote:
>>> On 4/19/21 11:22 PM, Carl Love via Gdb-patches wrote:
>>>> diff --git a/gdb/testsuite/lib/valgrind.exp b/gdb/testsuite/lib/valgrind.exp
>>>> index c214491f7b8..caabeda9730 100644
>>>> --- a/gdb/testsuite/lib/valgrind.exp
>>>> +++ b/gdb/testsuite/lib/valgrind.exp
>>>> @@ -82,12 +82,15 @@ proc vgdb_start { {active_at_startup 1} } {
>>>>  
>>>>      clean_restart $testfile
>>>>  
>>>> +    set vgdbcmd "set remotetimeout 3"
>>>> +
>>>>      # Make sure we're disconnected, in case we're testing with the
>>>>      # native-extended-gdbserver board, where gdb_start/gdb_load spawn
>>>>      # gdbserver and connect to it.
>>>>      gdb_test "disconnect" ".*"
>>>>  
>>>> -    set vgdbcmd "target remote | vgdb --wait=1 --pid=$vgdbpid"
>>>> +    set vgdbcmd "target remote | vgdb --wait=2 --max-invoke-ms=2500 --pid=$vgdbpid"
>>>> +
>>>>      if { $active_at_startup } {
>>>>  	gdb_test "$vgdbcmd" " in \\.?_start .*" "target remote for vgdb"
>>>>      } else {
>>>>
>>>
>>> AFAICT, the first "set vgdbcmd" doesn't achieve anything.
>>>
>>> The value is overwritten by the second "set vgdbcmd".
>>
>> This actually sets the remotetimeout, and increasing the value to 4
>> fixes the FAIL I reported:

Well done! I completely overlooked that. :-(

> 
> Patch below fixes the FAIL.
> 
> Any comments?

AFAICT, that looks like the correct way to do this.

Thank you for fixing this.

Keith