This is the mail archive of the gdb-prs@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

gdb/703: Think-o bug, Bad call to ..._read_register_dummy()


>Number:         703
>Category:       gdb
>Synopsis:       Think-o bug, Bad call to ..._read_register_dummy()
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 13 14:38:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     ac131313@redhat.com
>Release:        2002-09-13
>Organization:
>Environment:

>Description:
Just FYI,

The code ...

static void
avr_init_extra_frame_info (int fromleaf, struct frame_info *fi)
{
 ....
  if (PC_IN_CALL_DUMMY (fi->pc, fi->frame, fi->frame))
    {
      /* We need to setup fi->frame here because run_stack_dummy gets it wrong
         by assuming it's always FP.  */
      fi->frame = generic_read_register_dummy (fi->pc, fi->frame, fi->frame);
 
isn't right.  The third parameter to ..._read_register_dummy() is a REGNUM and not a frame address.  (I'm preparing a patch to rename _read_register_dummy and stumbled across this.)

You may want to pull the fix into 5.3.

enjoy,
Andrew

>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]