build/2277: mipsisa64-unknown-elf sim build failure, Makefile problem

[rask at sygehus dot dk]

>Number:         2277
>Category:       build
>Synopsis:       mipsisa64-unknown-elf sim build failure, Makefile problem
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 25 12:18:01 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     rask@sygehus.dk
>Release:        cvs HEAD
>Organization:
>Environment:
GNU Make 3.81, gcc version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)
Linux gcc12 2.6.18-4-vserver-amd64 #1 SMP Fri May 4 01:21:52 UTC 2007 x86_64 GNU/Linux
>Description:
I'm trying to build a simulator for mipsisa64-unknown-elf. With make -j2,
this happens:

gcc -c -DHAVE_CONFIG_H     -DPROFILE=1 -DWITH_PROFILE=-1   -DWITH_ALIGNMENT=NONSTRICT_ALIGNMENT -DWITH_TARGET_WORD_BITSIZE=64 -DWITH_TARGET_WORD_MSB=63 -DWITH_DEFAULT_TARGET_BYTE_ORDER=BIG_ENDIAN  -DWITH_FLOATING_POINT=HARD_FLOATING_POINT -DWITH_TARGET_FLOATING_POINT_BITSIZE=64 -DWITH_HW=0 -DWITH_HOST_BYTE_ORDER=LITTLE_ENDIAN    -DWITH_RESERVED_BITS=1  -DWITH_SMP=0  -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized    -DTARGET_ENABLE_FR=1 -DMIPS_MACH_DEFAULT=bfd_mach_mipsisa64   -I. -I/n/12/rask/src/all/sim/mips -I../common -I/n/12/rask/src/all/sim/mips/../common -I../../include -I/n/12/rask/src/all/sim/mips/../..//include -I../../bfd -I/n/12/rask/src/all/sim/mips/../..//bfd -I../../opcodes -I/n/12/rask/src/all/sim/mips/../..//opcodes  -g -O2 /n/12/rask/src/all/sim/mips/m16run.c
/n/12/rask/src/all/sim/mips/m16run.c:22:25: error: m16_idecode.h: No such file or directory
/n/12/rask/src/all/sim/mips/m16run.c:23:25: error: m32_idecode.h: No such file or directory
/n/12/rask/src/all/sim/mips/m16run.c: In function sim_engine_run:
/n/12/rask/src/all/sim/mips/m16run.c:49: error: m16_instruction_word undeclared (first use in this function)
/n/12/rask/src/all/sim/mips/m16run.c:49: error: (Each undeclared identifier is reported only once
/n/12/rask/src/all/sim/mips/m16run.c:49: error: for each function it appears in.)
/n/12/rask/src/all/sim/mips/m16run.c:49: error: expected ; before instruction_0
/n/12/rask/src/all/sim/mips/m16run.c:50: warning: implicit declaration of function m16_idecode_issue
/n/12/rask/src/all/sim/mips/m16run.c:50: error: instruction_0 undeclared (first use in this function)
/n/12/rask/src/all/sim/mips/m16run.c:54: error: m32_instruction_word undeclared (first use in this function)
/n/12/rask/src/all/sim/mips/m16run.c:54: error: expected ; before instruction_0
/n/12/rask/src/all/sim/mips/m16run.c:55: warning: implicit declaration of function m32_idecode_issue
make[3]: *** [m16run.o] Error 1
make[3]: *** Waiting for unfinished jobs....

m16run.o depends on m16_idecode.h and m32_idecode.h, but the Makefile doesn't say so.
>How-To-Repeat:
.../src/configure --target=mipsisa64-unknown-elf --with-newlib --enable-sim --disable-gdb --disable-nls
make -j2
>Fix:
This one-liner seems to fix it:

Index: sim/mips/Makefile.in
===================================================================
RCS file: /cvs/src/src/sim/mips/Makefile.in,v
retrieving revision 1.13
diff -u -r1.13 Makefile.in
--- sim/mips/Makefile.in        20 Feb 2007 13:28:55 -0000      1.13
+++ sim/mips/Makefile.in        25 Jun 2007 11:47:38 -0000
@@ -191,6 +191,7 @@
 m16_support.o: sim-main.h m16_support.c $(SIM_EXTRA_DEPS)
 m16_idecode.o: sim-main.h m16_idecode.c $(SIM_EXTRA_DEPS)
 m16_icache.o: sim-main.h m16_icache.c $(SIM_EXTRA_DEPS)
+m16run.o: $(srcdir)/m16run.c m16_idecode.h m32_idecode.h

 m32_semantics.o: sim-main.h m32_semantics.c $(SIM_EXTRA_DEPS)
 m32_support.o: sim-main.h m32_support.c $(SIM_EXTRA_DEPS)
>Release-Note:
>Audit-Trail:
>Unformatted: