This is the mail archive of the
gdb-prs@sourceware.org
mailing list for the GDB project.
Re: remote/2560: valid reponse packet can be treated as 'ENN'error packet
- From: Daniel Jacobowitz <drow at false dot org>
- To: nobody at sources dot redhat dot com
- Cc: gdb-prs at sources dot redhat dot com,
- Date: 2 Dec 2008 17:28:02 -0000
- Subject: Re: remote/2560: valid reponse packet can be treated as 'ENN'error packet
- Reply-to: Daniel Jacobowitz <drow at false dot org>
The following reply was made to PR remote/2560; it has been noted by GNATS.
From: Daniel Jacobowitz <drow@false.org>
To: richard.stuckey@arc.com
Cc: gdb-gnats@sources.redhat.com
Subject: Re: remote/2560: valid reponse packet can be treated as 'ENN'
error packet
Date: Tue, 2 Dec 2008 12:19:13 -0500
On Tue, Dec 02, 2008 at 05:04:33PM -0000, richard.stuckey@arc.com wrote:
> This test is too weak: if the response packet contains valid data which happens to begin with an 'E' then it will be incorrectly treated as an error.
remote_send is only used in four cases: p/P and g/G. If you
encountered it in one of those, I suggest sending back lowercase
hex rather than uppercase hex.
That does not invalidate your correct report; merely a suggestion.
--
Daniel Jacobowitz
CodeSourcery