[Bug gdb/16014] Coding error: 2 * sizeof( sizeof())

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

http://sourceware.org/bugzilla/show_bug.cgi?id=16014

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    sergiodj@sourceware.org    2013-10-16 02:55:27

Modified files:
    gdb            : ChangeLog dwarf2read.c 
    gdb/gdbserver  : ChangeLog tracepoint.c 

Log message:
    There were two functions who were calling "sizeof" twice.

    The first one, dw2_get_real_path from gdb/dwarf2read.c, was actually
    making use of OBSTACK_CALLOC which already calls "sizeof" for its third
    argument.

    The second, download_tracepoint_1 from gdb/gdbserver/tracepoint.c, was
    explicitly calling "sizeof" inside another "sizeof".

    This patch fixed both functions.

    gdb/ChangeLog
    2013-10-16  Sergio Durigan Junior  <sergiodj@redhat.com>

    PR gdb/16014
    * dwarf2read.c (dw2_get_real_path): Remove unnecessary call to
    sizeof.

    gdb/gdbserver/ChangeLog
    2013-10-16  Sergio Durigan Junior  <sergiodj@redhat.com>

    PR gdb/16014
    * tracepoint.c (download_tracepoint_1): Remove unnecessary double
    call to sizeof.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.16104&r2=1.16105
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/dwarf2read.c.diff?cvsroot=src&r1=1.843&r2=1.844
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/ChangeLog.diff?cvsroot=src&r1=1.776&r2=1.777
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/tracepoint.c.diff?cvsroot=src&r1=1.83&r2=1.84

-- 
You are receiving this mail because:
You are on the CC list for the bug.