This is the mail archive of the
gdb-prs@sourceware.org
mailing list for the GDB project.
[Bug remote/15974] Unsupported notification packets are causing errors (last of the nc_list is picked).
- From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>
- To: gdb-prs at sourceware dot org
- Date: Mon, 02 Dec 2013 06:47:55 +0000
- Subject: [Bug remote/15974] Unsupported notification packets are causing errors (last of the nc_list is picked).
- Auto-submitted: auto-generated
- References: <bug-15974-4717 at http dot sourceware dot org/bugzilla/>
http://sourceware.org/bugzilla/show_bug.cgi?id=15974
--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via 62972e0b66f4247f56c795ee55bc0825933a7bed (commit)
from f9b0da3d5833ad5f809422f3084b0ef8fa5c5762 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=62972e0b66f4247f56c795ee55bc0825933a7bed
commit 62972e0b66f4247f56c795ee55bc0825933a7bed
Author: Yao Qi <yao@codesourcery.com>
Date: Thu Aug 15 09:09:08 2013 +0800
Fix PR remote/15974
In remote-notif.c:handle_notification, we have a loop,
for (i = 0; i < ARRAY_SIZE (notifs); i++)
{
nc = notifs[i];
if (strncmp (buf, nc->name, strlen (nc->name)) == 0
&& buf[strlen (nc->name)] == ':')
break;
}
/* We ignore notifications we don't recognize, for compatibility
with newer stubs. */
if (nc == NULL)
return;
If the notification is not in the list 'notifs', the last entry is
used, which is wrong. It should be NULL. This patch fixes it.
gdb:
2013-12-02 Pedro Alves <palves@redhat.com>
PR remote/15974
* remote-notif.c (handle_notification): Return early if no
notification is found.
-----------------------------------------------------------------------
Summary of changes:
gdb/ChangeLog | 6 ++++++
gdb/remote-notif.c | 15 +++++++++------
2 files changed, 15 insertions(+), 6 deletions(-)
--
You are receiving this mail because:
You are on the CC list for the bug.