This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: RFC: gdbglobals.[ch]


Eli Zaretskii wrote:
> 
> > Date: Wed, 13 Dec 2000 14:37:26 +0000
> > From: Fernando Nasser <fnasser@cygnus.com>
> >
> > > > /* Obtain the current value of a global. */
> > > >
> > > > extern gdb_global_rc
> > > >            gdb_global_get_value (gdb_global_handle global, char **cur_val);
> > >
> > > Shouldn't the last argument be a "void **"?
> >
> > I initially defined it as a void ** but then I realized out set/show
> > facility and the commands.h stuff use char **.
> >
> > To minimize the conversion effort I thought of keeping it like it is now.
> >
> > I wonder if this was not done this way due to some compatibility problem.
> > Maybe the reason no longer exists anyway.
> 
> I suspect that was to pacify non-ANSI/non-ISO compilers.  Since we
> don't support those anymore, I'd suggest to use void **.  I'm afraid
> that a good ANSI compiler, and with the warning options we now use by
> default, will bitch at char **.

OK, I will change that in the final version.

Thanks.

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]