This is the mail archive of the
gdb@sourceware.cygnus.com
mailing list for the GDB project.
Re: Moving Linux-specific stuff out of i386-tdep.c
- To: gdb at sourceware dot cygnus dot com
- Subject: Re: Moving Linux-specific stuff out of i386-tdep.c
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Wed, 8 Mar 2000 15:27:42 -0700
- References: <200003082121.e28LLRu05681@delius.kettenis.local>
On Mar 8, 10:21pm, Mark Kettenis wrote:
> Over time quite a lot of Linux-dependent stuff has been added to
> i386-tdep.c, and I think it's time to move that into its own file.
> But before I do that I'd like to get some clarification on some
> issue's.
>
> 1. Do we still care about the filename limits of older System V
> systems? i386-linux-nat.c is longer than 14 characters which is a
> no-no according to the GNU conding standards.
I asked Andrew and Stan about this a short while ago. It seems that
the limits have been relaxed somewhat. (Stan proposed an 18 character
limit in our discussion.)
> 2. Should I postpone creating the new -tdep.c file until after the
> release or not. Andrew has been telling us to avoid gratuitous
> changes to make it easier to apply outstanding patches. But on the
> other hand, after 5.0 is released, I hope to see a lot new patches
> generated against 5.0. So creating the new file before 5.0 would
> make applying those new patches a lot easier.
If you have a handle on the outstanding patches (are there any?) to
i386-tdep.c, I think you should feel free to move platform specific
code to separate *-tdep.c files. Personally, I think it'd be better
for it to happen sooner rather than later.
Kevin