This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: DOS/Windows-specific code: source.c



"Eli Zaretskii" <eliz@is.elta.co.il> writes:
> Perhaps, but this is not the problem I was trying to solve.  The issue
> is whether _any_ platform needs to put O_BINARY into mode in this

If it's host-specific code, perhaps.  But it's better if nobody needs
to know whether or not O_BINARY is available; they only need to know
if it's *appropriate*.  If the file is binary, use O_BINARY.  If it is
text, don't.  On platforms where O_BINARY is zero, it does nothing,
but does prevent yet another needless host test.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]