This is the mail archive of the
gdb@sources.redhat.com
mailing list for the GDB project.
Re: When do cleanups happen?
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: Michael Snyder <msnyder at redhat dot com>
- Cc: gdb at sources dot redhat dot com, Daniel Jacobowitz <drow at mvista dot com>
- Date: Wed, 09 Jan 2002 19:36:36 -0500
- Subject: Re: When do cleanups happen?
- References: <20020109151622.A842@nevyn.them.org> <3C3CC1CD.798D57DB@redhat.com> <20020109181030.B6397@nevyn.them.org> <3C3CD52D.E01410D2@redhat.com>
> Daniel Jacobowitz wrote:
> [cleanups only happen if there is an error]
>
>>
>> On Wed, Jan 09, 2002 at 02:18:53PM -0800, Michael Snyder wrote:
>
>> > Cleanups are always done, no later than
>> > when the command is finished executing (if not earlier).
>
>>
>> Well, the comments in utils.c are wrong, then :)
>
>
> Hmm! Now I am confused.
>
> What do others think? Are cleanups cleaned-up only on error?
> Or always when a command finishes? I know that I have found
> that if I make a cleanup that closes a file, then I cannot close
> that file myself else it will wind up being closed twice.
Two styles:
oc = make_cleanup (close, fd); // yes ok that is bad
....blah blah
do_cleanups (oc);
which always does the close using the cleanup. This is kind of like a
TRY ... FINALLY .. END construct;
oc = make_cleanup (close, fd); // ...
... blah blah
discard_cleanups (oc); //* is that the right f name?
... blah blah
close (fd);
which discards the cleanups so you're free to do the close. This is
kind of a TRY ... EXCEPT ... END.
And then there is the truth:
catch_exceptions() / catch_errors() does a cleanup.
the main command loop has a do_cleanup() call.
enjoy,
Andrew