This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

make install DESTDIR=/tmp/foo fails in gdb head


I configured current gdb head branch, make install fails in dejagnu due
to the lack of $(DESTDIR) in install-data-local target.

~olaf//toolchain/src/gdb/gdb-head/src/configure \
--prefix=/home/olaf/gdb-head --disable-nls
make
make install DESTDIR=/tmp/foo-gdb-head

...
make[3]: Entering directory `/home/foo/obj-gdb/dejagnu'
/bin/sh /heim/olaf//toolchain/src/gdb/gdb-head/src/dejagnu/mkinstalldirs /tmp/foo-gdb-head/home/olaf/gdb-head/bin
 /usr/bin/ginstall -c /heim/olaf//toolchain/src/gdb/gdb-head/src/dejagnu/runtest /tmp/foo-gdb-head/home/olaf/gdb-head/bin/runtest
/bin/sh /heim/olaf//toolchain/src/gdb/gdb-head/src/dejagnu/mkinstalldirs /tmp/foo-gdb-head/home/olaf/gdb-head/libexec
 /usr/bin/ginstall -c /heim/olaf//toolchain/src/gdb/gdb-head/src/dejagnu/config.guess /tmp/foo-gdb-head/home/olaf/gdb-head/libexec/config.guess
/bin/sh /heim/olaf//toolchain/src/gdb/gdb-head/src/dejagnu/mkinstalldirs /tmp/foo-gdb-head/home/olaf/gdb-head/share/dejagnu
 /usr/bin/ginstall -c /heim/olaf//toolchain/src/gdb/gdb-head/src/dejagnu/runtest.exp /tmp/foo-gdb-head/home/olaf/gdb-head/share/dejagnu/runtest.exp
/bin/sh /heim/olaf//toolchain/src/gdb/gdb-head/src/dejagnu/mkinstalldirs /tmp/foo-gdb-head/home/olaf/gdb-head/share/dejagnu /home/olaf/gdb-head/include
mkdir /home/olaf
mkdir: cannot create directory `/home/olaf': Permission denied
mkdir /home/olaf/gdb-head
mkdir: cannot create directory `/home/olaf/gdb-head': No such file or directory
mkdir /home/olaf/gdb-head/include
mkdir: cannot create directory `/home/olaf/gdb-head/include': No such file or directory
make[3]: *** [install-data-local] Error 1
make[3]: Leaving directory `/home/foo/obj-gdb/dejagnu'
make[2]: *** [install-am] Error 2


This patch fixes a few places wher DESTDIR is missing.


Index: src/dejagnu/Makefile.am
===================================================================
RCS file: /cvs/src/src/dejagnu/Makefile.am,v
retrieving revision 1.4
diff -u -p -r1.4 Makefile.am
--- src/dejagnu/Makefile.am	10 Nov 2003 09:14:46 -0000	1.4
+++ src/dejagnu/Makefile.am	5 Jul 2004 21:25:20 -0000
@@ -124,7 +124,7 @@ install-info:
 uninstall-info:
 
 install-data-local:
-	$(mkinstalldirs) $(lib_dest) $(includedir)
+	$(mkinstalldirs) $(lib_dest) $(DESTDIR)$(includedir)
 	for f in $(lib_files); do \
 	  test ! -f "$$f" || $(INSTALL_DATA) $$f $(lib_dest); \
 	done
@@ -134,7 +134,7 @@ install-data-local:
 	  test ! -f "$$f" || $(INSTALL_DATA) $$f $(baseboards_dest); \
 	done
 	#
-	$(INSTALL_DATA) $(srcdir)/dejagnu.h $(includedir); \
+	$(INSTALL_DATA) $(srcdir)/dejagnu.h $(DESTDIR)$(includedir); \
 	#
 	$(mkinstalldirs) $(config_dest)
 	for f in $(config_files); do \
Index: src/expect/Makefile.in
===================================================================
RCS file: /cvs/src/src/expect/Makefile.in,v
retrieving revision 1.4
diff -u -p -r1.4 Makefile.in
--- src/expect/Makefile.in	22 Sep 2001 16:42:19 -0000	1.4
+++ src/expect/Makefile.in	5 Jul 2004 21:25:20 -0000
@@ -372,16 +372,16 @@ expecti$(EXEEXT): exp_main_exp.c $(EXP_U
 #   Local copy is pkgIndex rather than pkgIndex.tcl because pkgIndex.tcl.in
 #   is too long for some filesystems, sigh.
 install_shared_lib: $(EXP_LIB_FILES)
-	${srcdir}/mkinstalldirs $(libdir)
+	${srcdir}/mkinstalldirs $(DESTDIR)$(libdir)
 	if [ -s $(EXP_UNSHARED_LIB_FILE) ] ; then \
-	  $(INSTALL_DATA) $(EXP_UNSHARED_LIB_FILE) $(libdir)/$(EXP_UNSHARED_LIB_FILE) ; \
-	$(UNSHARED_RANLIB) $(libdir)/$(EXP_UNSHARED_LIB_FILE) ; \
-	$(INSTALL_DATA) $(EXP_UNSHARED_LIB_FILE) $(tcl_libdir)/$(EXP_UNSHARED_LIB_FILE) ; \
-	$(UNSHARED_RANLIB) $(tcl_libdir)/$(EXP_UNSHARED_LIB_FILE) ; \
+	  $(INSTALL_DATA) $(EXP_UNSHARED_LIB_FILE) $(DESTDIR)$(libdir)/$(EXP_UNSHARED_LIB_FILE) ; \
+	$(UNSHARED_RANLIB) $(DESTDIR)$(libdir)/$(EXP_UNSHARED_LIB_FILE) ; \
+	$(INSTALL_DATA) $(EXP_UNSHARED_LIB_FILE) $(DESTDIR)$(tcl_libdir)/$(EXP_UNSHARED_LIB_FILE) ; \
+	$(UNSHARED_RANLIB) $(DESTDIR)$(tcl_libdir)/$(EXP_UNSHARED_LIB_FILE) ; \
 	else true; fi
 	if [ -s $(EXP_SHARED_LIB_FILE) ] ; then \
-	  $(INSTALL_PROGRAM) $(EXP_SHARED_LIB_FILE) $(tcl_libdir)/$(EXP_SHARED_LIB_FILE) ; \
-	  $(INSTALL_PROGRAM) pkgIndex $(libdir)/pkgIndex.tcl ; \
+	  $(INSTALL_PROGRAM) $(EXP_SHARED_LIB_FILE) $(DESTDIR)$(tcl_libdir)/$(EXP_SHARED_LIB_FILE) ; \
+	  $(INSTALL_PROGRAM) pkgIndex $(DESTDIR)$(libdir)/pkgIndex.tcl ; \
 	else true; fi
 
 expect_installed$(EXEEXT): exp_main_exp.o $(EXP_LIB_FILE) install_shared_lib
@@ -430,58 +430,58 @@ install-info:
 
 # CYGNUS LOCAL: minimal/angela
 install-minimal: expect$(EXEEXT) pkgIndex
-	${srcdir}/mkinstalldirs $(man1dir) $(bindir)
+	${srcdir}/mkinstalldirs $(DESTDIR)$(man1dir) $(DESTDIR)$(bindir)
 # install Expect
-	$(INSTALL_PROGRAM) expect$(EXEEXT) $(bindir)/expect$(EXEEXT)
+	$(INSTALL_PROGRAM) expect$(EXEEXT) $(DESTDIR)$(bindir)/expect$(EXEEXT)
 # install Expect man page
-	$(INSTALL_DATA) $(srcdir)/expect.man $(man1dir)/expect.1
+	$(INSTALL_DATA) $(srcdir)/expect.man $(DESTDIR)$(man1dir)/expect.1
 # END CYGNUS LOCAL
 
 install: expect$(EXEEXT) expect_installed$(EXEEXT) ${X11_PROGS_INSTALLED} pkgIndex install_shared_lib
-	${srcdir}/mkinstalldirs $(man1dir) $(man3dir) $(bindir) $(libdir) $(includedir)
+	${srcdir}/mkinstalldirs $(DESTDIR)$(man1dir) $(DESTDIR)$(man3dir) $(DESTDIR)$(bindir) $(DESTDIR)$(libdir) $(DESTDIR)$(includedir)
 # install Expect
-	$(INSTALL_PROGRAM) expect_installed$(EXEEXT) $(bindir)/expect$(EXEEXT)
+	$(INSTALL_PROGRAM) expect_installed$(EXEEXT) $(DESTDIR)$(bindir)/expect$(EXEEXT)
 # install Expectk (and man page) if present
 	-if [ -s expectk_installed$(EXEEXT) ] ; then \
-	  $(INSTALL_PROGRAM) expectk_installed$(EXEEXT) $(bindir)/expectk$(EXEEXT) ; \
-	  $(INSTALL_DATA) $(srcdir)/expectk.man $(man1dir)/expectk.1 ; \
+	  $(INSTALL_PROGRAM) expectk_installed$(EXEEXT) $(DESTDIR)$(bindir)/expectk$(EXEEXT) ; \
+	  $(INSTALL_DATA) $(srcdir)/expectk.man $(DESTDIR)$(man1dir)/expectk.1 ; \
 	else true; fi
 # install Expect man page
-	$(INSTALL_DATA) $(srcdir)/expect.man $(man1dir)/expect.1
+	$(INSTALL_DATA) $(srcdir)/expect.man $(DESTDIR)$(man1dir)/expect.1
 # install man page for Expect and Expectk libraries
-	$(INSTALL_DATA) $(srcdir)/libexpect.man $(man3dir)/libexpect.3
+	$(INSTALL_DATA) $(srcdir)/libexpect.man $(DESTDIR)$(man3dir)/libexpect.3
 # install Expect's public include files
-#	$(INSTALL_DATA) expect_cf.h $(includedir)
-	$(INSTALL_DATA) $(srcdir)/expect.h $(includedir)
-	$(INSTALL_DATA) $(srcdir)/expect_tcl.h $(includedir)
-	$(INSTALL_DATA) $(srcdir)/expect_comm.h $(includedir)
+#	$(INSTALL_DATA) expect_cf.h $(DESTDIR)$(includedir)
+	$(INSTALL_DATA) $(srcdir)/expect.h $(DESTDIR)$(includedir)
+	$(INSTALL_DATA) $(srcdir)/expect_tcl.h $(DESTDIR)$(includedir)
+	$(INSTALL_DATA) $(srcdir)/expect_comm.h $(DESTDIR)$(includedir)
 # force installation of Tcl's private regexp definition - we simply have to
 # make it public in order for people to use Expect's C lib.
-	$(INSTALL_DATA) $(TCLHDIR)/tclRegexp.h $(includedir)
+	$(INSTALL_DATA) $(TCLHDIR)/tclRegexp.h $(DESTDIR)$(includedir)
 # install Debugger's public include file (just in case it's not there)
-	$(INSTALL_DATA) $(srcdir)/Dbg.h $(includedir)
+	$(INSTALL_DATA) $(srcdir)/Dbg.h $(DESTDIR)$(includedir)
 
 install-scripts: $(SCRIPTS)
 # some people don't install Tcl, sigh
 	TCL_LIBRARY=$(TCL_LIBRARY) ; \
 	   export TCL_LIBRARY ; \
 	   if $(LOCAL_EXPECT) $(srcdir)/fixcat ; then \
-	      $(INSTALL_DATA) $(srcdir)/fixcat $(EXECSCRIPTDIR)/cat-buffers ; \
+	      $(INSTALL_DATA) $(srcdir)/fixcat $(DESTDIR)$(EXECSCRIPTDIR)/cat-buffers ; \
 	   else true; fi
 # install standalone scripts and their man pages, if requested
-	${srcdir}/mkinstalldirs $(bindir_arch_indep) $(man1dir) $(SCRIPTDIR) $(EXECSCRIPTDIR)
+	${srcdir}/mkinstalldirs $(DESTDIR)$(bindir_arch_indep) $(DESTDIR)$(man1dir) $(DESTDIR)$(SCRIPTDIR) $(DESTDIR)$(EXECSCRIPTDIR)
 	-for i in $(SCRIPT_LIST) ; do \
 	  if [ -f $$i ] ; then \
-	    $(INSTALL_PROGRAM) $$i $(bindir_arch_indep)/$$i ; \
+	    $(INSTALL_PROGRAM) $$i $(DESTDIR)$(bindir_arch_indep)/$$i ; \
 	    rm -f $$i ; \
 	  else true; fi ; \
 	done
 	-for i in $(SCRIPT_MANPAGE_LIST) ; do \
 	  if [ -f $(srcdir)/example/$$i.man ] ; then \
-	    $(INSTALL_DATA) $(srcdir)/example/$$i.man $(man1dir)/$$i.1 ; \
+	    $(INSTALL_DATA) $(srcdir)/example/$$i.man $(DESTDIR)$(man1dir)/$$i.1 ; \
 	  else true; fi ; \
 	done
-	$(INSTALL_DATA) pkgIndex.tcl $(SCRIPTDIR)
+	$(INSTALL_DATA) pkgIndex.tcl $(DESTDIR)$(SCRIPTDIR)
 
 $(SCRIPT_LIST):
 	TCL_LIBRARY=$(TCL_LIBRARY) ; \
Index: src/sim/common/Makefile.in
===================================================================
RCS file: /cvs/src/src/sim/common/Makefile.in,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile.in
--- src/sim/common/Makefile.in	15 Jan 2004 21:25:06 -0000	1.5
+++ src/sim/common/Makefile.in	5 Jul 2004 21:25:21 -0000
@@ -119,10 +119,10 @@ install: install-man
 
 install-man: installdirs
 	n=`echo run | sed '$(program_transform_name)'`; \
-	$(INSTALL_DATA) $(srcdir)/run.1 $(man1dir)/$$n.1
+	$(INSTALL_DATA) $(srcdir)/run.1 $(DESTDIR)$(man1dir)/$$n.1
 
 installdirs:
-	$(SHELL) $(srcdir)/../../mkinstalldirs $(man1dir)
+	$(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(man1dir)
 
 Makefile: Makefile.in config.status
 	$(SHELL) ./config.status
Index: src/sim/ppc/Makefile.in
===================================================================
RCS file: /cvs/src/src/sim/ppc/Makefile.in,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile.in
--- src/sim/ppc/Makefile.in	15 Oct 2003 21:32:36 -0000	1.11
+++ src/sim/ppc/Makefile.in	5 Jul 2004 21:25:21 -0000
@@ -665,7 +665,7 @@ config.status: configure
 
 install: installdirs
 	n=`echo run | sed '$(program_transform_name)'`; \
-	$(INSTALL_PROGRAM) run$(EXEEXT) $(bindir)/$$n$(EXEEXT)
+	$(INSTALL_PROGRAM) run$(EXEEXT) $(DESTDIR)$(bindir)/$$n$(EXEEXT)
 
 installdirs:
-	$(SHELL) $(srcdir)/../../mkinstalldirs $(bindir)
+	$(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(bindir)
Index: src/tcl/Makefile.in
===================================================================
RCS file: /cvs/src/src/tcl/Makefile.in,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile.in
--- src/tcl/Makefile.in	26 Nov 2002 19:47:47 -0000	1.5
+++ src/tcl/Makefile.in	5 Jul 2004 21:25:21 -0000
@@ -16,7 +16,7 @@ all:
 	@test x"$(CONFIGDIR2)" = x"" || (cd "$(CONFIGDIR2)" && $(MAKE) $@)
 
 install test install-binaries install-libraries install-minimal:
-	@cd $(CONFIGDIR) && $(MAKE) $@
+	@cd $(CONFIGDIR) && $(MAKE) $@ INSTALL_ROOT=$(DESTDIR)
 
 mostlyclean-recursive clean-recursive distclean-recursive \
 maintainer-clean-recursive:
-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÃRNBERG


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]