This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] GDB testsuite patch.


On Tue, Aug 24, 2004 at 11:29:12PM -0500, Manoj Iyer wrote:
> 
> Hi all,
> 
> Here is a patch to gdb/lib/gdb.exp, this patch handles the case when the
> GDB that is tested is stripped and has no debugging information.
> 
> I have created this patch according to Michael's recomendations (see
> below).

Michael wrote:

> > Three of the four test scripts in gdb.gdb have their own 'setup_test',
> > and the fourth script has another copy of the same code.  I would like
> > to see the common code factored into one place, lib/self-support.exp.
> >
> > Then setup_test calls gdb_load which calls gdb_file_cmd.  You could get
> > into gdb_file_cmd and detect "(no debugging symbols found)" and add a
> > channel to return that information.  Or, in setup_test, you could
> > do something right after the call to gdb_load to check for debugging
> > symbols.
> >
> > If there are no debugging symbols, then I think that the test script
> > should return one UNRESOLVED result and not continue testing.
> >
> > I'm not sure UNRESOLVED is the right result.  Perhaps UNTESTED would
> > be better.  But not UNSUPPORTED -- UNSUPPORTED means that a feature
> > is missing in the system under test.

That's not the same as what you've done.  gdb_file_cmd should not
always fail for objects without debugging information, since there are
other tests that work OK without it.  This only applies to the gdb.gdb/
tests.

-- 
Daniel Jacobowitz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]