This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: Build question
- From: Danny Backx <danny dot backx at scarlet dot be>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: tromey at redhat dot com, gdb at sourceware dot org
- Date: Tue, 01 Sep 2009 22:12:08 +0200
- Subject: Re: Build question
- References: <1250803105.11282.96.camel@pavilion> <m3fxbl2jib.fsf@fleche.redhat.com> <83d46pgjkq.fsf@gnu.org> <1250877901.11282.116.camel@pavilion> <83ab1tgh9h.fsf@gnu.org> <1250880746.11282.128.camel@pavilion> <m3r5v425lu.fsf@fleche.redhat.com> <1250931899.11282.142.camel@pavilion> <83skfkfa4n.fsf@gnu.org> <1251095160.16357.352.camel@pavilion> <1251828295.6106.119.camel@pavilion> <83zl9e8nro.fsf@gnu.org>
- Reply-to: danny dot backx at scarlet dot be
On Tue, 2009-09-01 at 22:31 +0300, Eli Zaretskii wrote:
> > From: Danny Backx <danny.backx@scarlet.be>
> > Cc: tromey@redhat.com, gdb@sourceware.org
> > Date: Tue, 01 Sep 2009 20:04:55 +0200
> >
> > Getting most things I care about to work is done by simplifying
> > include/filenames.h so it unconditionally takes the DOS versions of
> > IS_DIR_SEPARATOR() and IS_ABSOLUTE_PATH().
>
> If Unix users will not be too unhappy about that, as Daniel says, I
> don't mind. But I still think it's a better idea to have a
> user-settable option to control that at runtime.
I'm not opposed to introducing user-settable options, I just phrased the
analysis based on what I saw.
> > The code in bfd/archive.c could probably be cleaned up based on
> > IS_DIR_SEPARATOR.
> Even better, just use lbasename or even basename.
Except (see also your other mail) this is in libiberty.
> > Same, I think, for gdb/cli/cli-cmds.c.
>
> No, this one needs another macro: FILENAME_PREFIX_LEN, which should be
> 1 on Posix platforms and 3 on DOS-ish systems. Use the DOS-ish
> variant on Posix systems if "d:/foo" is not an important file name.
Should I then look into :
- changing HAVE_DOS_BASED_FILE_SYSTEM into a variable
- doing the same thing for FILENAME_PREFIX_LEN and FILENAME_CMPN
Danny
--
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info