This is the mail archive of the
mailing list for the GDB project.
Re: gdb.arch vs. gdb.base gcore test cases
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb at sourceware dot org
- Date: Fri, 03 May 2013 15:15:57 +0200
- Subject: Re: gdb.arch vs. gdb.base gcore test cases
- References: <8761z0gvr7 dot fsf at br87z6lw dot de dot ibm dot com> <51839F41 dot 2050101 at redhat dot com>
Pedro Alves <firstname.lastname@example.org> writes:
> On 05/03/2013 12:15 PM, Andreas Arnez wrote:
>> The following two test cases are mostly identical, and their associated
>> C source files are exactly identical:
>> Is there any specific reason for the two copies? Just curious...
> Well, what does git blame, and the initial submission of the
> corresponding patches say? The answer probably lies in what makes them
> "mostly identical" rather than "exactly identical" being arch
> specific. If the differences are really small, then we could merge
> them into gcore.exp, using istarget to guard the arch specific bits.
The common test case was introduced some time ago:
2002-01-08 Michael Snyder <email@example.com>
* gdb.base/gcore.exp: New test for generate-core-file command.
* gdb.base/gcore.c: Testcase for above.
* gdb.threads/gcore-thread.exp: New test for gcore (threaded).
The x86-specific one is newer; it was introduced with this change:
2010-04-17 H.J. Lu <firstname.lastname@example.org>
* gdb.arch/system-gcore.exp: New.
* gdb.arch/gcore.c: Likewise.
The only functional difference seems to be that system-gcore.exp adds a
new comparison (before/after) for the output from "info reg system".