This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/5806] wrong comment in strlen() and other functions


------- Additional Comments From egmont at gmail dot com  2008-03-02 08:50 -------
Well, the comment does match to what the code is doing now, not in strlen.c but
all the other similar files wherever this comment appears (such as strchr.c just
to mention one.)

No need to fix the comments of course, provided that you change the
implementation in all these fourteen files, not just in strlen.c; and throw out
the old version, not just put inside #if 0. If you keep the old version around,
I recommend to fix the comments because it can be done very easily, and might be
a help to anyone trying to understand that.

The algorithm you linked from bug #5807 is definitely nicer than the current
one, easier to understand, and does exact match with no false positive.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5806

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]