[Bug dynamic-link/14370] ld.so crashes on mismatched TLS/non-TLS symbols

["hjl.tools at gmail dot com" <sourceware-bugzilla at sourceware dot org>]

http://sourceware.org/bugzilla/show_bug.cgi?id=14370

--- Comment #20 from H.J. Lu <hjl.tools at gmail dot com> 2012-09-04 22:22:26 UTC ---
(In reply to comment #18)
> (In reply to comment #17)
> > Here are before and after timings of "make all" and "make check".
> 
> H.J., Thanks for working on this...
> 
> This looks like your patch *improved* performance, of which I'm skeptical
> because it adds more instructions into the _dl_symbol_lookup_x hot path.

The performance impact is too small to be visible unless most
of time is spent in _dl_symbol_lookup_x.


> Are the build times from a cold reboot or after a "flush" to ensure the
> previous build didn't change the numbers?

No, I just built them twice without reboot.

> I don't like it that ld.so crashes, but I'm not sold that this is the best
> solution, but it certainly makes the dynamic linker more rugged and perhaps
> avoids what could possibly be used as an attack vector for a security breach.

Same here.

> Please post this to libc-alpha for wide review.

Done.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.