[Bug dynamic-link/15271] dlmopen()ed shared library with LM_ID_NEWLM crashes if it fails dlsym() twice

["carlos at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

http://sourceware.org/bugzilla/show_bug.cgi?id=15271

--- Comment #3 from Carlos O'Donell <carlos at redhat dot com> 2013-03-17 17:25:15 UTC ---
(In reply to comment #2)
> Hi Carlos,
> 
> I don't believe this patch is legally significant per
> http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant since it
> simply moves an existing function and replaces free() with check_free() in
> two locations in the code.
> 
> Furthermore, per this link I believe this is merely an "idea": a possible
> fix for this bug is to check the frees that are performed in
> _dlerror_run() and __dlerror().

Brian,

Thanks for clarifying that. Given that you don't think it's legally significant
I've had a look at the patch and I agree. I try not to look at patches until
copyright is settled, thanks for understanding and answering the question :-)

Firstly, please avoid the use of `ld' directly and instead use the compiler
driver `gcc' to link your shared library. Without a lot of care using `ld'
directly can cause problems.

The patch itself looks good and does fix this test case. I'm still double
checking that I didn't miss anything in the dlmopen() case.

How do you feel about doing a little more work?

* Add your test case to the glibc testsuite, you can see how other similar
tests are handled, and we have a test-skeleton.c that can be used to run tests
easily.

* Build and run the testsuite with `make -k check', and report back the
results.

I'm not trying to avoid work, just leaning on you, since you appear to be an
experienced developer and competent enough to have waded into dynamic loader
code for multiple namespace support... and we could use the help :-)

Please don't feel that you need to say yes to this additional work, but it will
help us speed up getting this patch into 2.18.

Is there a particular maintenance branch that you need or want this change for?
2.17? 2.16? Fedora? Debian? etc.

Cheers,
Carlos.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.