This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch, ibm/2.12/master, updated. glibc-2.12.1-47-g2c3d9ba
- From: rsa at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 1 Jul 2011 14:44:22 -0000
- Subject: GNU C Library master sources branch, ibm/2.12/master, updated. glibc-2.12.1-47-g2c3d9ba
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, ibm/2.12/master has been updated
via 2c3d9ba9a332cecb009b97ebac5bb78a13118c7c (commit)
from 8ff7fa1ab2f28cde64f5337dc4b6a984c41ced27 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sources.redhat.com/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=2c3d9ba9a332cecb009b97ebac5bb78a13118c7c
commit 2c3d9ba9a332cecb009b97ebac5bb78a13118c7c
Author: ryanarn <ryanarn@igoo.rchland.ibm.com>
Date: Fri Jul 1 09:42:21 2011 -0500
Remove pthread_attr_setstacksize from __aio_create_helper_thread.
diff --git a/ChangeLog b/ChangeLog
index 9ad4d2e..5ec2eb3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-06-30 Ryan S. Arnold <rsa@linux.vnet.ibm.com>
+
+ * nptl/sysdeps/unix/sysv/linux/aio_misc.h
+ (__aio_create_helper_thread): Remove call to
+ pthread_attr_setstacksize () which set the stacksize to
+ PTHREAD_STACK_MIN. This is too small if large amounts of TLS are in
+ use. Removing this call effectively sets stacksize to 'default'.
+
2011-03-15 Alan Modra <amodra@gmail.com>
* elf/dl-reloc.c (_dl_try_allocate_static_tls <TLS_DTV_AT_TP>): Handle
diff --git a/nptl/sysdeps/unix/sysv/linux/aio_misc.h b/nptl/sysdeps/unix/sysv/linux/aio_misc.h
index 406d96e..2bf7c17 100644
--- a/nptl/sysdeps/unix/sysv/linux/aio_misc.h
+++ b/nptl/sysdeps/unix/sysv/linux/aio_misc.h
@@ -46,8 +46,8 @@ __aio_create_helper_thread (pthread_t *threadp, void *(*tf) (void *),
pthread_attr_init (&attr);
pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED);
- /* The helper thread needs only very little resources. */
- (void) pthread_attr_setstacksize (&attr, PTHREAD_STACK_MIN);
+ /* Don't set the stacksize to PTHREAD_STACK_MIN. Let it default, otherwise
+ the stack may be too small if TLS is in use. */
/* Block all signals in the helper thread. To do this thoroughly we
temporarily have to block all signals here. */
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 8 ++++++++
nptl/sysdeps/unix/sysv/linux/aio_misc.h | 4 ++--
2 files changed, 10 insertions(+), 2 deletions(-)
hooks/post-receive
--
GNU C Library master sources